Skip to content

Conversation

valentinoli
Copy link

Click 8.3.0 includes breaking changes causing build failures in projects using Hatch. This commit pins the version to a version known to work with the current Hatch release.

#2050

Click 8.3.0 includes breaking changes causing build failures in projects using Hatch. This commit pins the version to a version known to work with the current Hatch release.
@valentinoli
Copy link
Author

valentinoli commented Sep 19, 2025

@ofek

This is currently causing all pipelines using Hatch to break

Can we be more strict with the version specifier?

This is not the first time it has happened. Also happened to my team when uv published a breaking change in v0.7.0

So perhaps consider pinning dependencies of Hatch strictly

@valentinoli
Copy link
Author

Another case in point: #2052

@mbercx
Copy link

mbercx commented Sep 20, 2025

To motivate this PR even more, note that the click developers don't strictly follow SemVer:

https://palletsprojects.com/versions#not-semver

You could also consider click=8.2.2 click~=8.2.1, since they still respect patch versions.

EDIT: Seems version 8.2.2 was yanked: https://pypi.org/project/click/8.2.2/

@Simon-Bru
Copy link

Would love to benefit from this too ! @ofek

@jorng
Copy link

jorng commented Sep 23, 2025

@ofek I'm sorry to add onto the pings, but this is breaking a huge number of projects out there using Hatch, and is a very straightforward change. Can we get this merged as quickly as you are able? We need a new version released to continue using Hatch.

@ofek
Copy link
Contributor

ofek commented Sep 23, 2025

#2050 (comment)

@ofek
Copy link
Contributor

ofek commented Sep 24, 2025

Thanks for the assist! We went with a slightly different fix in order to avoid pinning. https://github.com/pypa/hatch/releases/tag/hatch-v1.14.2

@ofek ofek closed this Sep 24, 2025
@valentinoli
Copy link
Author

@ofek Thank you. I am interested in understanding what you did to fix it. Could you elaborate?

@valentinoli valentinoli deleted the patch-2 branch September 24, 2025 09:19
@ofek
Copy link
Contributor

ofek commented Sep 24, 2025

#2053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants