Fix: Set default of None for @click.option("--filter", ...) #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With release of click v8.3.0, the click module is leaking click.core.UNSET where previously None was returned. This is causing the filter option on the run command to fail. Favoring explicit over implicit, we can avoid that issue without pinning back the click library.
psss
pushed a commit
to teemtee/tmt
that referenced
this pull request
Sep 22, 2025
I was hoping either hatch or click would create a quick bug-fix, but they are still stalled after the weekend. The PRs to follow are: - pypa/hatch#2053 - pallets/click#3068 Signed-off-by: Cristian Le <git@lecris.dev>
ofek
pushed a commit
that referenced
this pull request
Sep 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With release of click
v8.3.0, the click module is leakingclick.core.UNSETwhere previouslyNonewas returned.This is causing the filter option on the run command to fail.
Favoring explicit over implicit, we can avoid that issue without pinning back the click library.
Alternative
click.Fixes
fixes #2050