Use log1p(x) instead of log(1+x) #2539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is more accurate than torch.log() for small values of input - https://pytorch.org/docs/stable/generated/torch.log1p.html Found with https://github.com/pytorch-labs/torchfix/
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17010 17010
=======================================
Hits 17007 17007
Misses 3 3 ☔ View full report in Codecov by Sentry. |
saitcakmak
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks @kit1980! Happy to stamp the diff if you want to import the PR into fbcode.
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kit1980
added a commit
to pytorch-labs/torchfix
that referenced
this pull request
Sep 17, 2024
Suggest using `torch.log1p(x)` instead of `torch.log(1 + x)`. Only a checker for now, probably not worth spending time on a codemod as it's not a very common issue. I used this to create a PR to botorch pytorch/botorch#2539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is more accurate than torch.log() for small values of input - https://pytorch.org/docs/stable/generated/torch.log1p.html
Found with https://github.com/pytorch-labs/torchfix/