Use expm1 for log-normal transforms #2540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Replacing `exp(x) - 1` with the numerically more stable `expm1`. Differential Revision: D62789111
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62789111 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17010 17010
=======================================
Hits 17007 17007
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 238f05a. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 17, 2024
Summary: Similar to pytorch#2540, replaces `exp(x) - 1` with the numerically more stable `expm1`. Differential Revision: D62813775
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replacing
exp(x) - 1with the numerically more stableexpm1.Differential Revision: D62789111