Implement MultiTaskDataset.__eq__ #2594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, this would fallback to `SupervisedDataset.__eq__`, which uses `self.X` for comparison. If the underlying datasets have heterogeneous feature sets, `self.X` errors out. The new `MultiTaskDataset.__eq__` resolves this issue by comparing the underlying datasets one by one. Differential Revision: D64911436
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64911436 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17365 17367 +2
=======================================
+ Hits 17363 17365 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9d37e90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, this would fallback to
SupervisedDataset.__eq__, which usesself.Xfor comparison. If the underlying datasets have heterogeneous feature sets,self.Xerrors out.The new
MultiTaskDataset.__eq__resolves this issue by comparing the underlying datasets one by one.Differential Revision: D64911436