Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MultiTaskDataset.__eq__ #2594

Closed
wants to merge 1 commit into from
Closed

Implement MultiTaskDataset.__eq__ #2594

wants to merge 1 commit into from

Commits on Oct 24, 2024

  1. Implement MultiTaskDataset.__eq__ 

    Summary:
Previously, this would fallback to `SupervisedDataset.__eq__`, which uses `self.X` for comparison. If the underlying datasets have heterogeneous feature sets, `self.X` errors out.

The new `MultiTaskDataset.__eq__` resolves this issue by comparing the underlying datasets one by one.

Differential Revision: D64911436
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    78887bc View commit details
    Browse the repository at this point in the history