Remove Visdom dependency and update documentation #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove visdom from requirements-dev.txt - Add skip decorator to all visdom tests - Comment out visdom execution in GitHub Actions workflow - Add warning in VisdomLogger docstring - Update conftest.py to skip visdom server fixture Co-authored-by: vfdev-5 <2459423+vfdev-5@users.noreply.github.com>
- Add warning to setup_visdom_logging function docstring - Add skip decorator to test_setup_visdom_logging Co-authored-by: vfdev-5 <2459423+vfdev-5@users.noreply.github.com>
vfdev-5
reviewed
Feb 9, 2026
vfdev-5
reviewed
Feb 9, 2026
Copilot
AI
changed the title
[WIP] Remove Visdom dependency and update documentation
Remove unmaintained Visdom dependency
Feb 9, 2026
github-actions
bot
added
module: handlers
- Move visdom imports into visdom_server fixture body - Uncomment fixture code (will be skipped at runtime) - Simplify workflow comment to be more concise Co-authored-by: vfdev-5 <2459423+vfdev-5@users.noreply.github.com>
vfdev-5
reviewed
Feb 9, 2026
3 tasks
Since visdom is removed from requirements-dev.txt, pyrefly complains about the import. Add ignore comment to suppress the type checking error. Co-authored-by: vfdev-5 <2459423+vfdev-5@users.noreply.github.com>
Copilot
AI
changed the title
Remove unmaintained Visdom dependency
Add pyrefly ignore for visdom import to fix type checking
Feb 9, 2026
vfdev-5
changed the title
Co-authored-by: vfdev-5 <2459423+vfdev-5@users.noreply.github.com>
Copilot
AI
changed the title
Remove Visdom dependency and update documentation
Fix CI failures from visdom dependency removal
Feb 9, 2026
vfdev-5
changed the title
vfdev-5
approved these changes
Feb 9, 2026
Added TODO comment regarding py-rouge package and its dependency management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visdom package was removed from requirements-dev.txt as it's unmaintained and incompatible with modern Python packages. This caused CI failures in type checking and code style workflows.
Changes
# pyrefly: ignoreto visdom import inignite/handlers/visdom_logger.pysince pyrefly cannot verify types for unavailable optional dependenciestests/ignite/handlers/conftest.pyVisdomLogger remains available but displays warnings that it's untested. Tests skip gracefully when visdom is unavailable.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.