14 implement logger initialization logic #15

archeoss · 2023-09-23T10:26:03Z

Resolves #14

Merging #9 will make this PR easier to review

cli/src/config.rs

archeoss · 2023-10-03T13:42:01Z

14 implement logger initialization logic #15 👈
Create initial project structure (Backend) #9 : 1 other dependent PR (#10 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @archeoss and the rest of your teammates on Graphite

backend/src/config.rs

cli/src/config.rs

ikopylov · 2023-11-23T20:13:36Z

Please, fix merge conflicts

backend/src/config.rs

ikopylov · 2023-12-22T16:04:36Z

backend/src/config.rs

+    fn init_file_rotate(&self) -> Result<FileRotate<AppendTimestamp>, LoggerError> {
+        let config = self.file.as_ref().ok_or(LoggerError::EmptyConfig)?;
+        let log_file = config.log_file.as_ref().ok_or(LoggerError::NoFileName)?;
+        log_file


Unnecessary complication of code readability. The code would be much clearer in this form:

if log_file.as_os_str().is_empty() { return Err(LoggerError::NoFileName); }

backend/src/config.rs

ikopylov

LGTM

archeoss requested a review from ikopylov September 23, 2023 10:26

archeoss linked an issue Sep 23, 2023 that may be closed by this pull request

Implement logger initialization logic #14

Closed

ikopylov reviewed Sep 23, 2023

View reviewed changes

cli/src/config.rs Outdated Show resolved Hide resolved

archeoss changed the base branch from main to 1-init-project-backend October 3, 2023 13:41

archeoss force-pushed the 14-implement-logger-initialization-logic branch from 3da5b70 to 246ea40 Compare October 3, 2023 13:41

archeoss mentioned this pull request Oct 3, 2023

Create initial project structure (Backend) #9

Merged

This was referenced Oct 3, 2023

Create initial project structure (Frontend) #10

Merged

5 create dockerfile and docker compose to simplify deployment #12

Merged

11 configure cicd #13

Merged

archeoss requested a review from ikopylov October 3, 2023 13:45

archeoss force-pushed the 14-implement-logger-initialization-logic branch from 835b80c to e1a600a Compare October 3, 2023 22:08

archeoss mentioned this pull request Oct 5, 2023

Add login page (Backend) #16

Open

archeoss changed the base branch from 1-init-project-backend to main October 6, 2023 12:55

archeoss force-pushed the 14-implement-logger-initialization-logic branch from e1a600a to adf1f86 Compare October 6, 2023 12:56

archeoss mentioned this pull request Oct 13, 2023

Add login page (Frontend) #17

Open

archeoss force-pushed the 14-implement-logger-initialization-logic branch from adf1f86 to 3411daa Compare November 13, 2023 14:23

This was referenced Nov 15, 2023

3 add home page (Backend) #18

Open

4 Node list page (Backend) #19

Open

8 add VDisk list page #20

Open

7 add detailed info page #21

Open

ikopylov reviewed Nov 23, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

ikopylov reviewed Nov 23, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

ikopylov reviewed Nov 23, 2023

View reviewed changes

cli/src/config.rs Outdated Show resolved Hide resolved

archeoss added 5 commits November 27, 2023 17:15

add backend

cb952ac

post review fixes pt.1

f201390

post review fixes pt.2

8ad4e43

remove wrappers

b858a01

post review fixes (WIP)

2932ae8

archeoss added 8 commits November 27, 2023 17:41

add loggers

654d24a

clean up

c3d512e

remove dep

ec05d75

remove stderr target

d2f95eb

delete stderr target + unify trace-level

4e09e19

delete redundant lock file

11a1fcd

clean up

c621433

logger init rework

64263a2

archeoss force-pushed the 14-implement-logger-initialization-logic branch from 6271683 to 64263a2 Compare November 27, 2023 16:51

archeoss requested a review from ikopylov November 27, 2023 17:38

ikopylov reviewed Dec 4, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

ikopylov reviewed Dec 4, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

archeoss added 2 commits December 16, 2023 16:50

post review fixes + error_stack errors

0b2506c

adjust fixes

41801c8

archeoss requested a review from ikopylov December 17, 2023 05:50

Merge branch 'main' into 14-implement-logger-initialization-logic

9042706

ikopylov reviewed Dec 20, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

replace write check with is_empty check

8325256

archeoss requested a review from ikopylov December 22, 2023 06:28

ikopylov reviewed Dec 22, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

Update backend/src/config.rs

434d2fa

ikopylov reviewed Dec 22, 2023

View reviewed changes

backend/src/config.rs Outdated Show resolved Hide resolved

Update backend/src/config.rs

6dc1787

ikopylov approved these changes Dec 22, 2023

View reviewed changes

ikopylov merged commit d46cd94 into main Dec 22, 2023
13 checks passed

This was referenced Jan 29, 2024

[3] add home page #22

Open

[4] Add Nodelist page (frontend) #23

Open

[8] VDisk page (frontend) #24

Open

[7] Detailed Node Page (frontend) #25

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

14 implement logger initialization logic #15

14 implement logger initialization logic #15

archeoss commented Sep 23, 2023

archeoss commented Oct 3, 2023 •

edited

Loading

ikopylov commented Nov 23, 2023

ikopylov Dec 22, 2023

ikopylov left a comment

14 implement logger initialization logic #15

14 implement logger initialization logic #15

Conversation

archeoss commented Sep 23, 2023

archeoss commented Oct 3, 2023 • edited Loading

ikopylov commented Nov 23, 2023

ikopylov Dec 22, 2023

Choose a reason for hiding this comment

ikopylov left a comment

Choose a reason for hiding this comment

archeoss commented Oct 3, 2023 •

edited

Loading