7 add detailed info page #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
32f0039
to
02c5872
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
from
1f56c24
to
14d7edf
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
02c5872
to
b53f412
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
1a0e87e
to
1d9b344
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
2 times, most recently
from
e7bb19d
to
f8bdc8d
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
93ea824
to
7c92ccb
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
from
f8bdc8d
to
2231812
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
7c92ccb
to
197db21
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
from
2231812
to
2bdbf32
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
197db21
to
d4ac6db
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
from
2bdbf32
to
8903d49
Compare
archeoss
force-pushed
the
8-vdisk-list-page
branch
from
4fe4c4a
to
a0cd96c
Compare
archeoss
force-pushed
the
7-detailed-node-info-page
branch
from
12de748
to
af299d3
Compare
| tokio::spawn(async move { handle.clone().get_disks().await }) | ||
| }; | ||
|
|
||
| let Ok(Ok(GetStatusResponse::AJSONWithNodeInfo(status))) = status.await else { |
There was a problem hiding this comment.
Am I correct that tasks for metrics, space_info and disks will still run to completion even if function shortcircuits here? Wouldn't this approach result in many tasks running for every unsuccessful request?
| .ok_or(StatusCode::NOT_FOUND)?, | ||
| ); | ||
|
|
||
| let status = { |
There was a problem hiding this comment.
Probably this code can be extracted into macro, to prevent handle...spawn duplication?
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly resolves #7