Connectivity: Ethernet test fast-path + smarter DHCP handling for minimal builds by smuppand · Pull Request #235 · qualcomm-linux/qcom-linux-testkit

smuppand · 2025-12-18T17:46:08Z

This PR improves the Ethernet validation flow to be less disruptive, less flaky, and easier to debug on both full userland images (NetworkManager/systemd-networkd) and minimal/kernel-only style images.
What changed

Ethernet/run.sh
- Adds a fast-path: if an interface already has Link detected=yes and a valid IPv4 (non 169.254.x.x), the test skips bring-up + DHCP and directly validates connectivity via ping.
- Keeps existing behavior: if a network manager is active, the script does not run udhcpc and instead waits for IP.
- Improves debug logs for triage (interface snapshot + ping output).
functestlib.sh
- Updates try_dhcp_client_safe() to skip DHCP when a valid IP already exists.
- If systemctl is available and NetworkManager/systemd-networkd is active, it waits for IP rather than fighting the manager.
- Retains the safe udhcpc script flow for minimal images and adds extra logging for DHCP decisions/outcome.
Why
- Avoids re-running link bring-up/DHCP when the interface is already configured.
- Prevents conflicts with network managers on full images.
- Maintains usability on kernel/minimal environments where systemctl may not exist.
- Better logging helps debug intermittent link/IP issues quickly in CI/LAVA.

bhargav0610

LGTM

vnarapar · 2025-12-22T06:26:29Z

Please move 31f25f0 to first as we will see undefined function if we pick ec82b4d as head

Runner/suites/Connectivity/Ethernet/run.sh

smuppand · 2025-12-22T10:41:49Z

Please move 31f25f0 to first as we will see undefined function if we pick ec82b4d as head

Nice catch. I’ve moved the necessary commit to the head.

vnarapar · 2025-12-22T12:08:10Z

Can you remove this commit 62a7eef as we are no longer relying on user input? Also please update the readme

- In try_dhcp_client_safe(), detect a valid (non link-local) IPv4 early and return success without launching DHCP again. - When systemctl is available and NetworkManager/systemd-networkd is active, wait for IP instead of running udhcpc to avoid fighting the manager. - Keep the udhcpc safe-script behavior for minimal images while improving debug visibility around DHCP decisions and outcomes. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

smuppand · 2025-12-22T16:18:18Z

Can you remove this commit 62a7eef as we are no longer relying on user input? Also please update the readme

We cannot remove this commit because we need some of the changes it contains. I have pushed the latest updates.

- Add a fast-path: if Link detected=yes and a valid (non link-local) IPv4 is already present, skip link bring-up + IP acquisition and run ping directly. - Keep existing manager-aware behavior: when NetworkManager/systemd-networkd is active (via systemctl), don’t run udhcpc; only wait for IP. - Improve debug logs (ip-link / ethtool / ping output) for easier LAVA triage. - Preserve PASS/FAIL/SKIP summary reporting per interface. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

- Document auto-detection of Ethernet interfaces (not hardcoded eth0) - Mention manager-aware IP acquisition (NetworkManager/systemd-networkd) and the DHCP behavior when no manager is active - Describe fast-path when link + valid IPv4 already exist - Add new config knobs (LINK_TIMEOUT_S, IP_TIMEOUT_S, PING_* etc.) - Update result/summary expectations and sample logs - Note interface rename usage (e.g., end0) Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

vnarapar

LGTM

vnarapar · 2025-12-22T11:27:45Z

Runner/suites/Connectivity/Ethernet/run.sh

+    else
+        # Decide SKIP/FAIL post-failure
+        carrier="?"
+        if [ -r "/sys/class/net/$iface/carrier" ]; then


@smuppand hope Lines196- 199is not required as same is given at Line175 -> 178

vnarapar · 2025-12-22T11:31:02Z

Runner/suites/Connectivity/Ethernet/run.sh

+
+        log_info "Link bring-up failed for $iface. Diagnostics:"
+        ip link show "$iface" 2>/dev/null | while IFS= read -r l; do [ -n "$l" ] && log_info "[ip-link] $l"; done
+        ethtool "$iface" 2>/dev/null | sed -n '1,80p' | while IFS= read -r l; do [ -n "$l" ] && log_info "[ethtool] $l"; done


@smuppand 201 to 203 lines are also not required as they are checked at Line#180,181 and not operations performed inbetween

vnarapar · 2025-12-22T12:03:46Z

Runner/utils/functestlib.sh

+    ip link set "$iface" up >/dev/null 2>&1 || true
+
+    # If link is down/no cable, don't try DHCP
+    if command -v is_link_up >/dev/null 2>&1; then


if condition not required as is_link_up is helper function

vnarapar · 2025-12-22T12:04:12Z

Runner/utils/functestlib.sh

+            log_warn "$iface link is down; skipping DHCP"
+            return 1
+        fi
+    elif command -v ethIsLinkUp >/dev/null 2>&1; then


if condition not required as ethIsLinkUp is helper function

vnarapar · 2025-12-22T12:04:22Z

Runner/utils/functestlib.sh

+            return 1
+        fi
+    elif command -v ethIsLinkUp >/dev/null 2>&1; then
+        if ! ethIsLinkUp "$iface"; then


vnarapar · 2025-12-22T12:05:16Z

Runner/utils/functestlib.sh

+    fi
+
+    # 2) If helper exists and says up, accept it (but don't fail early)
+    if command -v is_link_up >/dev/null 2>&1; then


vnarapar · 2025-12-22T12:06:20Z

Runner/utils/functestlib.sh

+    init_autoneg=$(ethGetAutonegState "$iface" 2>/dev/null || echo "unknown")
+
+    # Bring interface up using existing helper (admin-up)
+    if command -v bringup_interface >/dev/null 2>&1; then


smuppand requested review from Vkenjam, bhargav0610 and vnarapar December 18, 2025 17:46

bhargav0610 approved these changes Dec 19, 2025

View reviewed changes

vnarapar mentioned this pull request Dec 22, 2025

Ethernet: Added force link speed on eth interface via ethtool #222

Closed

vnarapar reviewed Dec 22, 2025

View reviewed changes

Runner/suites/Connectivity/Ethernet/run.sh Outdated Show resolved Hide resolved

vnarapar reviewed Dec 22, 2025

View reviewed changes

Runner/suites/Connectivity/Ethernet/run.sh Outdated Show resolved Hide resolved

smuppand force-pushed the eth-dynamic-fix branch from e33f6a7 to 62a7eef Compare December 22, 2025 10:37

smuppand force-pushed the eth-dynamic-fix branch from 62a7eef to 30685dc Compare December 22, 2025 15:41

smuppand requested a review from vnarapar December 22, 2025 16:18

smuppand added 3 commits December 23, 2025 10:05

Rename the ethernet port from ETH to END.

5cdfb12

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

smuppand force-pushed the eth-dynamic-fix branch from 0a5b356 to f86d6e0 Compare December 23, 2025 04:51

vnarapar approved these changes Dec 23, 2025

View reviewed changes

vnarapar merged commit 08b0b34 into qualcomm-linux:main Dec 23, 2025
8 checks passed

Comments

Conversation

smuppand commented Dec 18, 2025

Uh oh!

bhargav0610 left a comment

Choose a reason for hiding this comment

Uh oh!

vnarapar commented Dec 22, 2025

Uh oh!

Uh oh!

Uh oh!

smuppand commented Dec 22, 2025

Uh oh!

vnarapar commented Dec 22, 2025

Uh oh!

smuppand commented Dec 22, 2025

Uh oh!

vnarapar left a comment

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

vnarapar Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants