-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for doc mapper update #5266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any juicy scenario suggestion is welcome
ideas of test i've run manually with various level of success, which represent some edge case i thought of:
|
9d37903
to
dee8f36
Compare
@trinity-1686a I added all your test scnarii Following your suggestion to test "u64 -> string, verify the field is still present after update", I changed the assert from just the number of hits to the whole hit content. I got 2 surprising results:
|
5673219
to
134ebe9
Compare
that's interesting, edit: gh wasn't showing me the whole file, the tests are already there. Still you'll need to disable them before we can merge |
done |
9c05694
to
0dbc44a
Compare
Description
Add some high level validation that searches still work after doc mapper update.
It would be interesting to do the same with aggregations.
Part of #5084
How was this PR tested?
NA (these are tests)