don't error on phrase query schema error for old splits #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
trinity-1686a
force-pushed
the
trinity/update-phrase-query
branch
from
4b9a04b
to
89e695c
Compare
rdettai
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
This fixes the bug (so approving the PR), but we should add unit tests to cover these scenarii and more. In the various files of the query_ast module there are some unit tests that could be extended. For instance in full_text_query.rs you have tests for some successful TantivyQueryAst builds. We should extend these against "all" possible schema field types (expected to be valid or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of #5084
don't execute phrase queries on old splits if they miss positions
How was this PR tested?
re-enabled tests