only return root spans for jaeger http api #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
reviewed
Aug 28, 2024
| @@ -353,7 +354,7 @@ mod tests { | |||
| async fn test_when_jaeger_not_found() { | |||
| let jaeger_api_handler = jaeger_api_handlers(None).recover(crate::rest::recover_fn_final); | |||
| let resp = warp::test::request() | |||
| .path("/otel-traces-v0_7/jaeger/api/services") | |||
| .path("/otel-traces-v0_9/jaeger/api/services") | |||
There was a problem hiding this comment.
you missed the one in the docstring https://github.com/quickwit-oss/quickwit/blob/main/quickwit/quickwit-serve/src/jaeger_api/rest_handler.rs#L60
There was a problem hiding this comment.
There was a problem hiding this comment.
this is already fixed in 7184ccd
fmassot
approved these changes
Aug 28, 2024
|
@trinity-1686a quick thought regarding your bump of OTEL_TRACES_INDEX_ID to |
|
some people are modifying their |
fmassot
pushed a commit
that referenced
this pull request
Sep 2, 2024
* only return root spans for jaeger http api * fix rest api tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on jaeger http api, return only root span. On grpc api, return all, otherwise jaeger shows empty traces until you reload the page
Can be improved once #5308 is merged, to stay mostly backward compatible (right now, the http api errors out, if
otel-traces-v0_7exists)How was this PR tested?
tested manually with jaeger, and grafana jaeger datasource pointed to quickwit