Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:missing protocol #59

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix:missing protocol #59

merged 2 commits into from
Sep 7, 2023

Conversation

JuaniRodriguez
Copy link
Contributor

Summary

GitHub links were being saved in the database without the HTTP/HTTPS protocol.

Details

  • Refactor GitHub Link RegExp.

  • Refactor variable in test case.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

LCOV of commit 9e72a72 during CI workflow #54

Summary coverage rate:
  lines......: 95.6% (538 of 563 lines)
  functions..: 98.6% (72 of 73 functions)
  branches...: 86.0% (153 of 178 branches)

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  src/utils/extractLinkFromSubmission.ts                                   |85.7%      7| 100%     1| 100%      1

@JuaniRodriguez JuaniRodriguez merged commit 10934de into main Sep 7, 2023
2 checks passed
@JuaniRodriguez JuaniRodriguez deleted the fix/missing-protocol branch September 7, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants