Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:missing protocol #59

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix:missing protocol #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76f706
refactor RegExp
JuaniRodriguez Sep 7, 2023
9e72a72
Refactor link variable
JuaniRodriguez Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/events/reaction/__test__/handleRobotFaceReaction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ describe('handleRobotFaceReaction', () => {

describe('GitHub link type', () => {
it('should save only the github link from the submission successfully', async () => {
const typeLinkText = 'github.com/r-argentina-programa/robotina';
const typeLinkText = 'https://github.com/r-argentina-programa/robotina';

const submissionResponseMock = {
completed: false,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/extractLinkFromSubmission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const extractLinkFromSubmission = (message: string): string => {
const linkRegex = /\bgithub\.com\/\S+\b/;
const linkRegex = /\bhttps?:\/\/github\.com\/\S+\b/;
const match = message.match(linkRegex);

if (match) {
Expand Down
Loading