-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: assert events emitted from contract #216
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #216 +/- ##
============================================
+ Coverage 45.92% 48.89% +2.97%
============================================
Files 47 47
Lines 4279 4532 +253
Branches 4279 4532 +253
============================================
+ Hits 1965 2216 +251
- Misses 2252 2254 +2
Partials 62 62 |
@Daanvdplas Could I receive review for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left small nitpicks.
This PR is going to daan/api but I'm not sure whether we want this. I say we really focus on getting frank/extension
merged and then rebase those small PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things need tweaking I'm afraid: return type of call not checked before emitting events, token terminology throughout (may want to get that PR merged first) and then it needs conflicts resolving.
pop-api/integration-tests/contracts/create_token_in_constructor/lib.rs
Outdated
Show resolved
Hide resolved
pop-api/integration-tests/contracts/create_token_in_constructor/lib.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pleased with the event naming.
Link to issue: #181
Refactor fungible
integration-tests
contract to emit events by default and catch those events in the integration test cases.