Better Debug for Storybook + Popper API Improvements #155
Conversation
Watermelon AI SummaryThis PR introduces enhancements to the Popper component within the Storybook environment, improving functionality and styling for better on-screen positioning, and adding a ScrollPlayground component for more effective debugging and testing of pop-up related features. GitHub PRs
ui is an open repo and Watermelon will serve it for free. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 5 5
Lines 32 32
Branches 8 8
=======================================
Hits 29 29
Misses 3 3 ☔ View full report in Codecov by Sentry. |
| return <div> | ||
| <Popper open={true} placement="bottom-start" popperName="dropdown" pop={<PopElem/>}> | ||
| return <div className='relative'> | ||
| <Popper open={false} placement="bottom-start" popperName="dropdown" pop={<PopElem/>}> |
There was a problem hiding this comment.
was the previous open flag a mistake? i havent looked at dropdown component yet
There was a problem hiding this comment.
dropdown is still a test component - its not part of the library yet :D
| @@ -0,0 +1,34 @@ | |||
| import React, {useState} from 'react'; | |||
There was a problem hiding this comment.
this is for storybook ya?
This PR improves popper component by adding the right combination of hooks to make popper work in generic scenarios
Also added a scroll container playground component that helps us test/debug popper related components