-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Debug for Storybook + Popper API Improvements #155
Merged
kotAPI
merged 3 commits into
main
from
pranay/popper-improvements-storybook-better-debug
Dec 31, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React, {useState} from 'react'; | ||
|
||
|
||
import Button from '~/components/ui/Button/Button'; | ||
|
||
const ScrollPlayground = ({children}) => { | ||
const [scrollable, setScrollable] = useState(false); | ||
|
||
const handleScrollableChange = (e) => { | ||
setScrollable((scrollable) => !scrollable); | ||
|
||
setTimeout(() => { | ||
const elem = document.getElementById('middle'); | ||
if (elem) { | ||
elem.scrollIntoView(); | ||
} | ||
}, 100); | ||
}; | ||
|
||
const SCROLL_BOUNDING_BOX = 200; | ||
|
||
return <div className='block bg-plum-200 relative p-2 overflow-auto' style={{height: '300px', width: '300px'}}> | ||
<Button onClick={handleScrollableChange}>{scrollable?'Disable':'Enable Scrollable'}</Button> | ||
<div className='mt-10' style={scrollable?{height: SCROLL_BOUNDING_BOX*4, width: SCROLL_BOUNDING_BOX*4}:{}}> | ||
<div style={scrollable?{marginTop: SCROLL_BOUNDING_BOX*2, paddingLeft: SCROLL_BOUNDING_BOX*2}:{}}> | ||
<span id="middle"> | ||
{children} | ||
</span> | ||
</div> | ||
</div> | ||
</div>; | ||
}; | ||
|
||
export default ScrollPlayground; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,8 @@ const Dropdown = ({list=[], selected}) => { | |
})} | ||
</ul>; | ||
}; | ||
return <div> | ||
<Popper open={true} placement="bottom-start" popperName="dropdown" pop={<PopElem/>}> | ||
return <div className='relative'> | ||
<Popper open={false} placement="bottom-start" popperName="dropdown" pop={<PopElem/>}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was the previous There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dropdown is still a test component - its not part of the library yet :D |
||
<span>Dropdown</span> | ||
</Popper> | ||
</div>; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for storybook ya?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct 👍