chore: bump AGP to 8.4.2 for building with Android 15 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetksh
reviewed
Oct 24, 2024
| @@ -16,7 +16,7 @@ ext.CONFIG.versions = [ | |||
| support : '26.0.0', | |||
| volley : '1.1.1', | |||
| ], | |||
| plugin: '7.2.0', | |||
| plugin: '8.4.2', | |||
There was a problem hiding this comment.
As per this : https://developer.android.com/build/releases/gradle-plugin#api-level-support
Minimum AGP version for API level 35 is 8.6.0.
As per this : https://developer.android.com/tools/releases/platforms#15
API Level 35 is for Android 15,
so, should we make it 8.6.0, then ?
There was a problem hiding this comment.
Should we also not update the Kotlin version at line#10 of this file ?
- I think
1.5.21is not being used by any project as it seems to be too old. 1.6.10is configured but that too looks outdated, I think1.9.0is required now.
There was a problem hiding this comment.
If we consider this : https://kotlinlang.org/docs/gradle-configure-project.html#kotlin-and-java-sources
- "2.0.21" should be the KGP (Kotlin Gradle Plugin) version
There was a problem hiding this comment.
I am just curious to know
- how do we make use of it ?
- I mean is it required for
testalso ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.