Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump AGP to 8.4.2 for building with Android 15 #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: bump AGP to 8.4.2 for building with Android 15 #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dd5ace
chore: bump agp to 8.4.2 for Android 15
maureenorea-clores Sep 30, 2024
178d67d
readme
maureenorea-clores Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ To ensure usability we follow these rules:

## Versions <a name="versions"></a>

### 9.3.0 (2024-10-03)
* Added support for building with SDK 35 (Android 15):
* Updated Android Gradle plugin version to 8.4.2.

### 9.2.1 (2022-12-29)
* Quality/Detekt: removed usage of obsolete `fail-fast` and `test-pattern` properties.

Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/test/resources/build_script_dependency.gradle
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just curious to know

  • how do we make use of it ?
  • I mean is it required for test also ?

Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.2.0'
classpath 'com.android.tools.build:gradle:8.4.2'
}
}
6 changes: 3 additions & 3 deletions quality/jacoco/android.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ def addJacocoTask(variant) {
jacocoTask.description = "Generate Jacoco Report for variant $variantName"

jacocoTask.reports {
csv.enabled false
html.enabled true
xml.enabled true
csv.required = false
html.required = true
xml.required = true
}

def excludedFiles = [
Expand Down
2 changes: 1 addition & 1 deletion versions/versions.gradle
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also not update the Kotlin version at line#10 of this file ?

  • I think 1.5.21 is not being used by any project as it seems to be too old.
  • 1.6.10 is configured but that too looks outdated, I think 1.9.0 is required now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we consider this : https://kotlinlang.org/docs/gradle-configure-project.html#kotlin-and-java-sources

  • "2.0.21" should be the KGP (Kotlin Gradle Plugin) version

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ext.CONFIG.versions = [
support : '26.0.0',
volley : '1.1.1',
],
plugin: '7.2.0',
plugin: '8.4.2',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this : https://developer.android.com/build/releases/gradle-plugin#api-level-support
Minimum AGP version for API level 35 is 8.6.0.

As per this : https://developer.android.com/tools/releases/platforms#15
API Level 35 is for Android 15,

so, should we make it 8.6.0, then ?

sdk : [
compile: 31,
target : 31,
Expand Down