Adding image check to pull request workflow and bumping scripts version #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasmlp
commented
Aug 17, 2023
lucasmlp
commented
- Adds a new step in the pull request workflow to check all the container images used in the project
- The step will run only if the pull request is opened against a release branch
- If the step fails, the workflow doesn't fail. The reason for this is that we have two tags from the fluent-bit repository that doesn't exist in Docker Hub. Until we figure that out, the new step would fail all the PRs if it was required to run successfully. After sorting the tags out we'll set the step success to be required.
diogoasouza
approved these changes
Aug 18, 2023
rohitsakala
reviewed
Aug 18, 2023
| - name: Check container images | ||
| run: make check-images | ||
| if: startsWith(github.ref, 'refs/heads/upstream/release-v') |
There was a problem hiding this comment.
This needs to run for every PR so we catch the errors beforehand and not until the release date of charts.
rohitsakala
reviewed
Aug 18, 2023
| run: make check-images | ||
| if: startsWith(github.ref, 'refs/heads/upstream/release-v') | ||
| continue-on-error: true |
There was a problem hiding this comment.
This field can be removed since this is the last step in the process.
|
Also, for the missing images, can we create a PR for adding the missing images in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.