Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding image check to pull request workflow and bumping scripts version #2881

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Adding image check to pull request workflow and bumping scripts version #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,12 @@ jobs:
run: sudo make validate

- name: Run Hull tests
run: cd tests && go test -v ./...
run: cd tests && go test -v ./...

- name: Check container images
run: make check-images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to run for every PR so we catch the errors beforehand and not until the release date of charts.

if: startsWith(github.ref, 'refs/heads/upstream/release-v')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field can be removed since this is the last step in the process.

continue-on-error: true
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ remove:
forward-port:
./scripts/forward-port

TARGETS := prepare patch clean clean-cache charts list index unzip zip standardize validate template regsync
TARGETS := prepare patch clean clean-cache charts list index unzip zip standardize validate template regsync check-images

$(TARGETS):
@./scripts/pull-scripts
Expand Down
2 changes: 1 addition & 1 deletion scripts/version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
set -e

CHARTS_BUILD_SCRIPTS_REPO=https://github.com/rancher/charts-build-scripts.git
CHARTS_BUILD_SCRIPT_VERSION="${CHARTS_BUILD_SCRIPT_VERSION:-v0.4.4}"
CHARTS_BUILD_SCRIPT_VERSION="${CHARTS_BUILD_SCRIPT_VERSION:-v0.4.6}"
Loading