Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.8] Remove doNotRelease tag from Fleet and add Fleet 0.8.0 rc.9 #2937

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

thardeck
Copy link
Contributor

@thardeck thardeck commented Sep 5, 2023

following the branching strategy guide.

I am using yq version 4 to change the release.yaml that's why the indentation of it is changed a bit.

Sadly `yq` enforces indentation for arrays atm because of this issue: https://github.com/mikefarah/yq/issues/1309
That's why I have to fix the indentation with sed manually after using yq.
Maybe we should enforce `yq` default indentation for the release.yaml in the future so manual fixes are not required.

@thardeck thardeck self-assigned this Sep 5, 2023
@rohitsakala
Copy link
Member

@thardeck Could you create an issue for yq ? and add team/mapps and next up label so that we can work on it later

@rohitsakala rohitsakala merged commit dcdc8c7 into dev-v2.8 Sep 5, 2023
3 checks passed
@thardeck
Copy link
Contributor Author

thardeck commented Sep 6, 2023

@thardeck Could you create an issue for yq ? and add team/mapps and next up label so that we can work on it later

I have created an issue: https://github.com/rancher/charts/issues/2949

@thardeck thardeck deleted the add_fleet_0.8.0-rc-9_and_fix_dev_28_branch branch September 6, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants