Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.7.11] Update sriov version to 102.2.0 #3449

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Feb 8, 2024

Issue: #44350

Problem

Add support for k8s v1.17

Testing

Deploy charts via helm using a three node RKE2 v1.27.9+rke2r1

Copy link

github-actions bot commented Feb 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Feb 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Feb 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Feb 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rohitsakala rohitsakala requested review from a team and removed request for rohitsakala February 10, 2024 16:32
Copy link
Contributor

@adamkpickering adamkpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please perform the validation steps, give the "Validation steps" comment a thumbs up, and re-run the "Validation Check" github actions run, and you should be able to merge this.

@adamkpickering adamkpickering added regsync-ready PR ready to sync images with prime registry and removed regsync-ready PR ready to sync images with prime registry labels Feb 12, 2024
Add support for k8s v1.17

Signed-off-by: Michael Fritch <mfritch@suse.com>
Use the `repository` annotation instead of `images` to support
chart deployment in an air-gap environment

Signed-off-by: Michael Fritch <mfritch@suse.com>
Signed-off-by: Michael Fritch <mfritch@suse.com>
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mgfritch mgfritch merged commit cfd867e into rancher:dev-v2.7.11 Feb 12, 2024
5 checks passed
@mgfritch mgfritch deleted the dev-v2.7.11-sriov-102.2.0 branch February 12, 2024 20:02
nicholasSUSE pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Michael Fritch <mfritch@suse.com>
nicholasSUSE pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Michael Fritch <mfritch@suse.com>
nicholasSUSE pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Michael Fritch <mfritch@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants