Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tarball upgrade capability #155

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Adding Tarball upgrade capability #155

merged 7 commits into from
Oct 2, 2023

Conversation

mddamato
Copy link
Contributor

Reference PR #153 and #154

This was referenced Sep 29, 2023
Closed
Closed
@Daemonslayer2048
Copy link
Contributor

Daemonslayer2048 commented Oct 2, 2023 •
edited
Loading

  • Code reviewed
  • Scenarios Tested:
    • Yum install
    • Tarball images install, docs
    • Tarball install, docs
    • Tarball upgrade
      • Upgrading via tarball from v1.27.6+rke2r1 to v1.28.2+rke2r1 worked without a hitch

All tests above were done on Rocky 8.8

Daemonslayer2048
Daemonslayer2048 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Daemonslayer2048 Daemonslayer2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment for tests I ran outside of the github actions.

@Daemonslayer2048 Daemonslayer2048 merged commit 3b9f8e8 into main Oct 2, 2023
@Daemonslayer2048 Daemonslayer2048 deleted the aceeric-tarball-upgrade branch October 2, 2023 16:40
@Daemonslayer2048 Daemonslayer2048 mentioned this pull request Oct 2, 2023
Closed
@mddamato mddamato mentioned this pull request Oct 3, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daemonslayer2048 Daemonslayer2048 Daemonslayer2048 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mddamato @Daemonslayer2048