Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed squidpy as docs dependency; using scanpy instead #99

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

anushka255
Copy link
Collaborator

I realized that squidpy is not compatible with numpy>2.0, so removed it as a dependency. Squidpy was only used to visualize spots, so now I'm using the same functionality provided by scanpy.

@anushka255 anushka255 mentioned this pull request Dec 2, 2024
@vineetbansal
Copy link
Contributor

squidpy doesn't seem to declare that it needs numpy<2. Is there some minimal code/stacktrace that proves they're mistaken? If the problem is in a smaller 3rd party library we should pin that instead. I feel even if we don't use squidpy right now, its an important library in the domain and will be used sooner or later by someone using paste3.

@anushka255 anushka255 changed the title Removed squidgy as docs dependency; using scanpy instead Removed squidpy as docs dependency; using scanpy instead Dec 2, 2024
Copy link
Contributor

@vineetbansal vineetbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@anushka255 anushka255 merged commit 0468d03 into main Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants