Add support for filtered search to the tiered_index code#1012
Open
benfred wants to merge 8 commits intorapidsai:release/25.12from
Open
Add support for filtered search to the tiered_index code#1012benfred wants to merge 8 commits intorapidsai:release/25.12from
benfred wants to merge 8 commits intorapidsai:release/25.12from
Conversation
The tiered_index code wasn't working with filtered search - since the filter passed to the brute force portion wasn't translating for the number of rows seen already. Fix and add a python level unittest that would have caught this. Also: * expose 'tiered_index.compact' to python * add maven as a dependency of the java bindings
benfred
added
improvement
cjnolet
reviewed
Jun 12, 2025
| - nccl>=2.19 | ||
| - ninja | ||
| - numpy>=1.23,<3.0a0 | ||
| - numpydoc | ||
| - openblas | ||
| - openjdk=22.* |
Member
There was a problem hiding this comment.
Don't need to do it in this PR, but at some point, I think we should separate the different languages into different "environment" files so that a user working predominently on Java, for example, doesn't need to have Go and Rust things installed.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
benfred
requested review from
a team
and removed request for
a team and
AyodeAwe
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tiered_index code wasn't working with filtered search - since the filter passed to the brute force portion wasn't translating for the number of rows seen already. Fix and add a python level unittest that would have caught this.
Also: