feat: setup interaction testing #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grade-react-native-72.3
anuraghazra
reviewed
Dec 26, 2023
Comment on lines
+34
to
+41
| iPhone6: { | ||
| name: 'iPhone 6', | ||
| styles: { | ||
| height: '667px', | ||
| width: '375px', | ||
| }, | ||
| type: 'mobile', | ||
| }, |
There was a problem hiding this comment.
Does the MINIMAL_VIEWPORTS doesn't have any mobile viewport by default?
There was a problem hiding this comment.
they have weird viewports like iPhone-5 or smaller so i added standard one
anuraghazra
reviewed
Dec 26, 2023
| await expect(onChange).toBeCalledWith(0); | ||
| getByText(/Single Flow To Collect And Disburse Payments/)?.scrollIntoView({ behavior: 'smooth' }); | ||
| await sleep(1000); | ||
| await expect(onChange).toBeCalledWith(3); |
There was a problem hiding this comment.
Actually we should also do this, after all the toBeCalledWith are done we should do another check for.
onChange.toBeCalledTimes(3);
This will ensure that onChange hasn't been called twice or more than it needs to be.
This we can add in all the tests.
anuraghazra
reviewed
Dec 26, 2023
|
|
||
| TestAutoPlay.play = async ({ canvasElement }) => { | ||
| const { getByRole } = within(canvasElement); | ||
| await sleep(8000); |
There was a problem hiding this comment.
Before this we should do onChange.not.toHaveBeenCalled()
anuraghazra
added a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Chaitanya Deorukhkar <deorukhkarchaitanya@gmail.com> Co-authored-by: Nitin Kumar <nitin.kumar@razorpay.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com> Co-authored-by: anuraghazra <anurag.hazra@razorpay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following things:
Run Interaction Testlabel or trigger it manually from the actions tab