fix: npmrc registry url #2112

anuraghazra · 2024-04-03T08:04:26Z

Description

Changes

Forced npm registry to use the default npm registry instead of our local machine's razorpay scoped registry. (Since we are not using any private packages)
Fixed yarn resolutions for react types. Since we had to regenerate the yarn.lock things got messed up

Additional Information

Component Checklist

Update Component Status Page
Perform Manual Testing in Other Browsers
Add KitchenSink Story
Add Interaction Tests (if applicable)
Add changeset

changeset-bot · 2024-04-03T08:04:30Z

⚠️ No Changeset found

Latest commit: f72c1b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-04-03T09:06:33Z

✅ PR title follows Conventional Commits specification.

snitin315 · 2024-04-03T10:40:53Z

packages/blade/package.json

    "react": "18.2.0",
+    "@types/react": "17.0.38",


We should target upgrading types to v18

chaitanyadeorukhkar · 2024-04-04T05:46:46Z

.npmrc

@@ -0,0 +1 @@
+@razorpay:registry=https://registry.npmjs.org/


Isn't the default npmjs registry?

chaitanyadeorukhkar · 2024-04-04T05:46:59Z

packages/blade/package.json

@@ -250,7 +250,7 @@
    "react-native": "0.72.3",
    "react-native-gesture-handler": "2.9.0",
    "react-native-reanimated": "3.4.2",
-    "react-native-svg": "12.3.0",
+    "react-native-svg": "15.1.0",


v12 types are not compatible with react18 types.

plus we and most of our consumers are using react-native >v70, thus according to this table we should be using v15 of rnsvg.

codesandbox-ci · 2024-04-04T08:57:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f72c1b5:

Sandbox	Source
razorpay/blade: basic	Configuration

rzpcibot · 2024-04-04T09:23:08Z

Bundle Size Report

Updated Components

Status	Component	Base Size (kb)	Current Size (kb)	Diff
⬇	Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem	7.597	7.324	-0.273 KB
⬇	ActionList, ActionListItem, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection	12.829	12.598	-0.231 KB
⬇	Alert	11.775	11.573	-0.202 KB
⬇	Amount	1.329	1.142	-0.187 KB
⬇	Badge	1.050	0.860	-0.190 KB
⬇	BladeProvider	1.868	1.694	-0.174 KB
⬇	BottomSheet	9.723	9.455	-0.268 KB
⬇	Box	0.977	0.790	-0.187 KB
⬇	Breadcrumb, BreadcrumbItem	2.776	2.576	-0.200 KB
⬇	ButtonGroup	1.373	1.179	-0.194 KB
⬇	Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing	9.424	9.215	-0.209 KB
⬇	Carousel, CarouselItem	7.061	6.869	-0.192 KB
⬇	Checkbox	6.248	6.038	-0.210 KB
⬇	Chip, ChipGroup	5.585	5.383	-0.202 KB
⬇	Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody	9.696	9.484	-0.212 KB
⬇	Counter	1.002	0.821	-0.181 KB
⬇	Divider	0.770	0.567	-0.203 KB
⬇	Drawer, DrawerBody, DrawerHeader	16.186	16.157	-0.029 KB
⬆	Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader	22.991	23.047	+0.056 KB
⬇	FileUpload	13.737	13.514	-0.223 KB
⬇	Indicator	1.142	0.965	-0.177 KB
⬇	List, ListItem, ListItemLink, ListItemCode, ListItemText	5.305	5.116	-0.189 KB
⬆	Modal	12.815	12.841	+0.026 KB
⬆	Popover, PopoverInteractiveWrapper	20.557	20.649	+0.092 KB
⬇	ProgressBar	1.927	1.734	-0.193 KB
⬇	Radio	5.001	4.760	-0.241 KB
⬇	Skeleton	1.013	0.804	-0.209 KB
⬆	SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep	28.564	28.568	+0.004 KB
⬇	Switch	4.773	4.546	-0.227 KB
⬇	Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions	51.921	51.914	-0.007 KB
⬇	Tabs, TabItem, TabList, TabPanel	6.835	6.652	-0.183 KB
⬇	Tag	3.675	3.479	-0.196 KB
⬇	ToastContainer, useToast	12.994	12.793	-0.201 KB
⬆	Tooltip, TooltipInteractiveWrapper	15.426	15.490	+0.064 KB
⬇	Button	6.220	6.005	-0.215 KB
⬇	IconButton	1.017	0.809	-0.208 KB
⬇	CheckboxGroup	4.407	4.202	-0.205 KB
⬇	SelectInput, AutoComplete	18.918	18.709	-0.209 KB
⬇	OTPInput	13.037	12.821	-0.216 KB
⬇	PasswordInput	14.966	14.760	-0.206 KB
⬇	PhoneNumberInput	48.597	48.556	-0.041 KB
⬇	TextArea	13.325	13.101	-0.224 KB
⬇	TextInput	14.966	14.743	-0.223 KB
⬇	Link	2.346	2.153	-0.193 KB
⬇	RadioGroup	4.362	4.170	-0.192 KB
⬇	Spinner	2.161	1.950	-0.211 KB
⬇	Code	0.840	0.645	-0.195 KB
⬇	Display	0.736	0.544	-0.192 KB
⬇	Heading, getHeadingProps	0.681	0.486	-0.195 KB
⬇	Text	0.233	0.003	-0.230 KB

Generated by 🚫 dangerJS against f72c1b5

saurabhdaware

Looks good overall. Can you check if we can do something about those anys 🙈

saurabhdaware · 2024-04-05T06:24:17Z

.github/workflows/blade-pr-title-check.yml

@@ -2,7 +2,7 @@ name: Blade PR Title Check

 on:
  pull_request_target:
-    types: [open, edited, synchronize]
+    types: [opened, edited, synchronize]


This was incorrect all along? how was it working 😄 ?

saurabhdaware · 2024-04-05T06:24:55Z

package.json

-    "@types/react-native": "0.64.4",
-    "@types/styled-components": "5.1.25",
-    "@types/styled-components-react-native": "5.1.3",
+    "@types/react": "18.2.24",


styled-components, react-native types not needed?

Oh just saw they are added in blade's package.json. So why is types/react needed here but types/styled-components are in blade's package.json?

packages/blade/src/components/ActionList/ActionListBox.native.tsx

fix: npmrc registry url

96ae131

chore: fix types

d9da196

anuraghazra requested review from chaitanyadeorukhkar, kamleshchandnani, snitin315 and saurabhdaware as code owners April 3, 2024 09:06

anuraghazra added 6 commits April 3, 2024 14:43

chore: update lock

9e42731

chore: update

189462b

chore: update

e601fe2

chore: update

4fe5f3a

chore: update

3d870c3

chore: update

5d0fc47

snitin315 reviewed Apr 3, 2024

View reviewed changes

anuraghazra added 3 commits April 3, 2024 16:14

chore: update

df9e898

chore: update

4507b0a

chore: update storybookjs

c1786b5

chaitanyadeorukhkar reviewed Apr 4, 2024

View reviewed changes

.npmrc

@@ -0,0 +1 @@

@razorpay:registry=https://registry.npmjs.org/

Copy link

Collaborator

chaitanyadeorukhkar Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the default npmjs registry?

chaitanyadeorukhkar reviewed Apr 4, 2024

View reviewed changes

anuraghazra added 2 commits April 4, 2024 12:48

Merge remote-tracking branch 'origin' into anu/registry-url-fix

dc2edf9

chore: fix build

c0c13f6

anuraghazra added 3 commits April 4, 2024 14:39

chore: fix build

396d3d0

chore: update

d1e6408

chore: update snaps

f72c1b5

saurabhdaware reviewed Apr 5, 2024

View reviewed changes

kamleshchandnani approved these changes Apr 5, 2024

View reviewed changes

kamleshchandnani merged commit 460a23d into master Apr 5, 2024
17 checks passed

kamleshchandnani deleted the anu/registry-url-fix branch April 5, 2024 06:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: npmrc registry url #2112

fix: npmrc registry url #2112

anuraghazra commented Apr 3, 2024 •

edited

Loading

changeset-bot bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

snitin315 Apr 3, 2024

chaitanyadeorukhkar Apr 4, 2024

chaitanyadeorukhkar Apr 4, 2024

anuraghazra Apr 4, 2024 •

edited

Loading

codesandbox-ci bot commented Apr 4, 2024 •

edited

Loading

rzpcibot commented Apr 4, 2024 •

edited

Loading

saurabhdaware left a comment

saurabhdaware Apr 5, 2024

saurabhdaware Apr 5, 2024

saurabhdaware Apr 5, 2024

fix: npmrc registry url #2112

fix: npmrc registry url #2112

Conversation

anuraghazra commented Apr 3, 2024 • edited Loading

Description

Changes

Additional Information

Component Checklist

changeset-bot bot commented Apr 3, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Apr 3, 2024 • edited Loading

snitin315 Apr 3, 2024

Choose a reason for hiding this comment

chaitanyadeorukhkar Apr 4, 2024

Choose a reason for hiding this comment

chaitanyadeorukhkar Apr 4, 2024

Choose a reason for hiding this comment

anuraghazra Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

codesandbox-ci bot commented Apr 4, 2024 • edited Loading

rzpcibot commented Apr 4, 2024 • edited Loading

Bundle Size Report

saurabhdaware left a comment

Choose a reason for hiding this comment

saurabhdaware Apr 5, 2024

Choose a reason for hiding this comment

saurabhdaware Apr 5, 2024

Choose a reason for hiding this comment

saurabhdaware Apr 5, 2024

Choose a reason for hiding this comment

anuraghazra commented Apr 3, 2024 •

edited

Loading

changeset-bot bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

anuraghazra Apr 4, 2024 •

edited

Loading

codesandbox-ci bot commented Apr 4, 2024 •

edited

Loading

rzpcibot commented Apr 4, 2024 •

edited

Loading