-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: npmrc registry url #2112
fix: npmrc registry url #2112
Changes from 10 commits
96ae131
d9da196
9e42731
189462b
e601fe2
4fe5f3a
3d870c3
5d0fc47
df9e898
4507b0a
c1786b5
dc2edf9
c0c13f6
396d3d0
d1e6408
f72c1b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
@razorpay:registry=https://registry.npmjs.org/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't the default npmjs registry? |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,7 +208,7 @@ | |
"@types/jest-axe": "3.5.5", | ||
"@types/jscodeshift": "0.11.6", | ||
"@types/jsdom": "20.0.1", | ||
"@types/react": "17.0.38", | ||
"@types/react": "18.2.74", | ||
"@types/react-native": "0.72.2", | ||
"@types/react-test-renderer": "17.0.1", | ||
"@types/styled-components": "5.1.25", | ||
|
@@ -250,7 +250,7 @@ | |
"react-native": "0.72.3", | ||
"react-native-gesture-handler": "2.9.0", | ||
"react-native-reanimated": "3.4.2", | ||
"react-native-svg": "12.3.0", | ||
"react-native-svg": "15.1.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. v12 types are not compatible with react18 types. plus we and most of our consumers are using react-native >v70, thus according to this table we should be using v15 of rnsvg. |
||
"react-scripts": "5.0.1", | ||
"react-test-renderer": "18.2.0", | ||
"rollup": "3.28.1", | ||
|
@@ -306,6 +306,7 @@ | |
"@storybook/**/react": "18.2.0", | ||
"react-dom": "18.2.0", | ||
"react": "18.2.0", | ||
"@types/react": "18.2.74", | ||
"styled-components": "^5" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was incorrect all along? how was it working 😄 ?