Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextArea): Tagged Inputs #2119

Merged
merged 22 commits into from
Apr 18, 2024
Merged

feat(TextArea): Tagged Inputs #2119

merged 22 commits into from
Apr 18, 2024

Conversation

saurabhdaware
Copy link
Member

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5cbd351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@saurabhdaware saurabhdaware marked this pull request as ready for review April 10, 2024 04:21
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 12, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5cbd351:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Apr 12, 2024 •
edited
Loading

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬆ Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.281 7.291 +0.010 KB
⬆ ActionList, ActionListItem, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 12.555 12.567 +0.012 KB
⬆ Alert 11.530 11.541 +0.011 KB
⬆ Amount 1.121 1.135 +0.014 KB
⬆ Badge 0.817 0.830 +0.013 KB
⬆ BladeProvider 1.651 1.662 +0.011 KB
⬆ BottomSheet 9.412 9.422 +0.010 KB
⬆ Box 0.747 0.759 +0.012 KB
⬆ Breadcrumb, BreadcrumbItem 2.533 2.543 +0.010 KB
⬆ ButtonGroup 1.136 1.152 +0.016 KB
⬆ Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing 9.172 9.175 +0.003 KB
⬆ Carousel, CarouselItem 6.826 6.838 +0.012 KB
⬆ Checkbox 5.995 6.012 +0.017 KB
⬆ Chip, ChipGroup 5.340 5.354 +0.014 KB
⬆ Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody 9.441 9.458 +0.017 KB
⬆ Counter 0.778 0.790 +0.012 KB
⬆ Divider 0.524 0.537 +0.013 KB
⬆ Drawer, DrawerBody, DrawerHeader 16.114 16.123 +0.009 KB
⬆ Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 23.004 23.009 +0.005 KB
⬆ FileUpload 13.471 13.476 +0.005 KB
⬆ Indicator 0.922 0.937 +0.015 KB
⬆ List, ListItem, ListItemLink, ListItemCode, ListItemText 5.073 5.079 +0.006 KB
⬆ Modal 12.798 12.808 +0.010 KB
⬆ Popover, PopoverInteractiveWrapper 20.606 20.615 +0.009 KB
⬆ ProgressBar 1.691 1.701 +0.010 KB
⬆ Radio 4.717 4.733 +0.016 KB
⬆ Skeleton 0.761 0.773 +0.012 KB
⬆ SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep 28.525 28.531 +0.006 KB
⬆ Switch 4.503 4.516 +0.013 KB
⬆ Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions 51.871 52.061 +0.190 KB
⬆ Tabs, TabItem, TabList, TabPanel 6.609 6.621 +0.012 KB
⬆ Tag 3.436 3.441 +0.005 KB
⬆ ToastContainer, useToast 12.750 12.751 +0.001 KB
⬆ Tooltip, TooltipInteractiveWrapper 15.447 15.457 +0.010 KB
⬆ Button 5.962 5.977 +0.015 KB
⬆ IconButton 0.766 0.778 +0.012 KB
⬆ CheckboxGroup 4.159 4.172 +0.013 KB
⬆ SelectInput, AutoComplete 18.666 19.060 +0.394 KB
⬆ OTPInput 12.778 13.158 +0.380 KB
⬆ PasswordInput 14.717 15.112 +0.395 KB
⬆ PhoneNumberInput 48.513 48.688 +0.175 KB
⬆ TextArea 13.058 15.647 +2.589 KB
⬆ TextInput 14.700 17.225 +2.525 KB
⬆ Link 2.110 2.119 +0.009 KB
⬆ RadioGroup 4.127 4.138 +0.011 KB
⬆ Spinner 1.907 1.920 +0.013 KB
⬆ Code 0.602 0.614 +0.012 KB
⬆ Display 0.501 0.513 +0.012 KB
⬆ Heading, getHeadingProps 0.443 0.456 +0.013 KB
⬆ Text -0.040 0.003 +0.043 KB

Generated by 🚫 dangerJS against 5cbd351

@saurabhdaware saurabhdaware added the Review - L1 First level of review label Apr 12, 2024
anuraghazra
anuraghazra reviewed Apr 12, 2024
View reviewed changes
packages/blade/src/components/Input/BaseInput/useTaggedInput.ts
const currentTags = tags ?? tagsUncontrolled;
const isControlledValue = value !== undefined;
const inputValue = isControlledValue ? value?.trim() : inputValueUncontrolled.trim();
if (e.key === 'Enter' || e.key === ',') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about " " space? Do we not create tags on pressing SPACE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. the tag itself might have space at some places no 🤔

@saurabhdaware saurabhdaware added Review - L2 Second level of review and removed Review - L1 First level of review labels Apr 15, 2024
chaitanyadeorukhkar
chaitanyadeorukhkar reviewed Apr 17, 2024
View reviewed changes
.changeset/pink-rocks-bake.md
---

feat(TextArea): Tagged Inputs
feat(Tag): max-width is removed from Tag component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a minor bump since there are changes to tag as well as new prop additions?

chaitanyadeorukhkar
chaitanyadeorukhkar reviewed Apr 17, 2024
View reviewed changes
.changeset/pink-rocks-bake.md Outdated
"@razorpay/blade": patch
---

feat(TextArea): Tagged Inputs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have also added this to TextInput right?

Lets format the changelog a bit better

@saurabhdaware saurabhdaware merged commit c5f24ea into master Apr 18, 2024
17 checks passed
@saurabhdaware saurabhdaware deleted the feat/tagged-inputs branch April 18, 2024 02:44
@anuraghazra anuraghazra mentioned this pull request Apr 22, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraghazra anuraghazra anuraghazra left review comments

@chaitanyadeorukhkar chaitanyadeorukhkar chaitanyadeorukhkar approved these changes

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

Assignees

@chaitanyadeorukhkar chaitanyadeorukhkar

Labels
Review - L2 Second level of review Run Interaction Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurabhdaware @rzpcibot @chaitanyadeorukhkar @anuraghazra