Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated player changes #175

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Integrated player changes #175

wants to merge 12 commits into from

Conversation

Eswar2103
Copy link
Contributor

Description

Enter a detailed description of the PR here, including the nature and purpose of the changes.

JIRA Ticket

Include a link to the JIRA Ticket linked to this PR.
Issue-0000

Additional Info (Test steps / Steps to reproduce etc.)

Details on how to test the feature

@Eswar2103 Eswar2103 changed the base branch from main to dev July 18, 2024 16:08
@github-actions GitHub Actions
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.2.0 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/pubsub/handlers/setApiResponseHandler.js
  106:4  error  Delete `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

neeradanelxsi
neeradanelxsi reviewed Jul 30, 2024
View reviewed changes
src/FireboltExampleInvoker.js
@@ -100,6 +100,13 @@ export const MODULE_MAP = {
discovery: DISCOVERY_MODULE_MAP,
};

try {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

neeradanelxsi
neeradanelxsi reviewed Jul 30, 2024
View reviewed changes
src/pubsub/handlers/setApiResponseHandler.js
@@ -102,4 +104,13 @@ export default class SetApiResponseHandler extends BaseHandler {
const reportIdString = JSON.stringify({ report: 'Received UserInterest apiResponse parameters' });
return reportIdString;
}

setExternalResponse(message) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neeradanelxsi neeradanelxsi neeradanelxsi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eswar2103 @neeradanelxsi