-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated player changes #175
Open
Eswar2103
wants to merge
12
commits into
dev
Choose a base branch
from
integratedPlayer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
71db08f
FireboltExampleInvoker import change
Eswar2103 eb39f6c
Fixed unit testcase failure
Eswar2103 97c07cd
Revert the fireboltExampleInvoker import
Eswar2103 78f81b1
Player provider registration changes
Eswar2103 780b34d
Minor fix
Eswar2103 94e47ac
Reverted external provider registration
Eswar2103 48b4854
Removed unused constants
Eswar2103 16dec1c
Generic way of importing additionalInvokers
Eswar2103 541ca88
Added set apiResponse for external module
Eswar2103 e423849
Latest changes
Eswar2103 6947f9e
Latest changes
Eswar2103 0da0e3e
Added comments to functions
Eswar2103 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,8 @@ export default class SetApiResponseHandler extends BaseHandler { | |
return this.setResponseAckChallenge(message); | ||
case 'userinterest': | ||
return this.setResponseUserInterestChallenge(message); | ||
case 'external': | ||
return this.setExternalResponse(message); | ||
default: | ||
const defaultIdString = JSON.stringify({ | ||
report: 'Selected module provider is not available', | ||
|
@@ -102,4 +104,14 @@ export default class SetApiResponseHandler extends BaseHandler { | |
const reportIdString = JSON.stringify({ report: 'Received UserInterest apiResponse parameters' }); | ||
return reportIdString; | ||
} | ||
|
||
// importing external Api resonse function, which can set the pre-requisite values to external modules | ||
setExternalResponse(message) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. function description There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
try { | ||
const externalFunction = require('../../../plugins/setExternalApiResponse'); | ||
return externalFunction.setExternalApiResponse(message); | ||
} catch (err) { | ||
return JSON.stringify({ report: 'Unable to import and set the data for external module' }); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done