-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specific deactivation of table handling #1218
base: master
Are you sure you want to change the base?
Conversation
Setting the table class "rtd-exclude-wy-table" deactivates the normal table handling for this table. So the table gets not wrapped into a "div.wy-table-responsive" container. Needed by other Sphinx extensions, which care about their tables on their own. Fixes readthedocs#1179
Thanks for the contribution, we'll see about getting this in version 1.1. I'll block this PR for now, we're still wrapping up a 1.0 release. |
@agjohnson Thanks for your feedback and for the overall work on RTD. The change itself is really small, one line. Not having a possibility of deactivating the automatic table handling makes RTD-Theme incompatible with some other sphinx-extensions. I, as an affected extension developer, would be happy to avoid this incompatibility as fast as possible. The other solution would be to ask my users to use another theme or use the fork, which contains my changes. |
We'll look to getting this in for 1.1, we don't want to keep holding back a 1.0 release. |
This issue is extremely critical for us. The fix solves a major problem that is affecting 100s of tables that we have in RTD theme. Any chance to get this in soon? |
@agjohnson I was looking for a way to accomplish the same thing from the sphinx side but could not find it. Found the following documentation that gives options for setting
Also, the js handling the responsive tables is on the theme side and it applies to every table that is not Line 102 in 3532ffc
Although this is not an ideal solution, I think it's a good option to add. Maybe instead of This would also fix: #1246 |
Any updates on this? |
Setting the table class "rtd-exclude-wy-table"
deactivates the normal table handling for this
table.
So the table gets not wrapped into a
"div.wy-table-responsive" container.
Needed by other Sphinx extensions, which
care about their tables on their own.
Fixes #1179