Fix: Disable dynamic plugin cache PVC by default #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortune-Ndlovu
force-pushed
the
RHIDP-5569-defaultly-disable-dynamic-plugin-cache-pvc
branch
from
a33ac3f to
d37799f
Compare
rm3l
requested changes
Feb 4, 2025
rm3l
reviewed
Feb 4, 2025
rm3l
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Also, could you update the CI values file accordingly, to reflect how people would specify a different storage class name for this ephemeral PVC?
rm3l
requested changes
Feb 5, 2025
charts/backstage/ci/with-custom-dynamic-pvc-claim-spec-values.yaml
Outdated
Show resolved
Hide resolved
Fortune-Ndlovu
force-pushed
the
RHIDP-5569-defaultly-disable-dynamic-plugin-cache-pvc
branch
2 times, most recently
from
8846abf to
33145e8
Compare
rm3l
requested changes
Feb 6, 2025
charts/backstage/ci/with-custom-dynamic-pvc-claim-spec-values.yaml
Outdated
Show resolved
Hide resolved
charts/backstage/ci/with-custom-dynamic-pvc-claim-spec-values.yaml
Outdated
Show resolved
Hide resolved
Fortune-Ndlovu
force-pushed
the
RHIDP-5569-defaultly-disable-dynamic-plugin-cache-pvc
branch
6 times, most recently
from
65cfa88 to
de7d416
Compare
Fortune-Ndlovu
force-pushed
the
RHIDP-5569-defaultly-disable-dynamic-plugin-cache-pvc
branch
from
de7d416 to
4096934
Compare
|
|
This PR was unintentionally closed after a forced reset (git reset --hard origin/main). Because of that, GitHub does not allow reopening it. Creating a new PR with the same changes...#94 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes the
dynamicPluginssection entirely and makes the dynamic plugin cache fully ephemeral by default in the RHDH Helm Chart. Instead of handling PVC creation within the chart, users can now configure an ephemeral volume claim directly underextraVolumes.Additionally, the chart version has been updated to 3.0.0 as this introduces a breaking change compared to the previous version. This does not impact the downstream chart version, which remains at 1.5.0.
Changes
dynamicPlugins.cache.volumeClaimSpecfromvalues.yaml, ensuring all dynamic plugin storage is ephemeral.extraVolumesto define ephemeral volume claims directly, making storage configuration more explicit.ci/with-custom-dynamic-pvc-claim-spec-values.yaml) to reflect how users can specify storage options for the ephemeral volume claim, including storage class configurations.charts/backstage/Chart.yamlversion to3.0.0, marking this as a breaking change.How to Test
helm upgrade --install rhdh-backstage charts/backstage --namespace rhdh oc get pvc -n rhdh # No PVC should be presentExisting or Associated Issue(s)
https://issues.redhat.com/browse/RHIDP-5569
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.