fix!: Disable dynamic plugin cache PVC by default [RHIDP-5569] #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rhdh-bot service account <rhdh-bot@redhat.com>
Fortune-Ndlovu
force-pushed
the
RHIDP-5569-default-disable-dynamic-plugin-cache-pvc
branch
from
508b001 to
ccd918c
Compare
…lm chart documentation with helm-docs Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…/with-custom-dynamic-pvc-claim-spec-values.yaml
4 tasks
|
cc @rm3l for review |
|
/cc |
rm3l
requested changes
Feb 10, 2025
In your "How to test" section from your PR description, there will actually be a PVC created, except that it will be ephemeral and tied to a single pod. |
|
rm3l
changed the title
rm3l
changed the title
openshift-merge-bot
bot
merged commit 89f0ba9
into
redhat-developer:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes the
dynamicPluginssection entirely and makes the dynamic plugin cache fully ephemeral by default in the RHDH Helm Chart. Instead of handling PVC creation within the chart, users can now configure an ephemeral volume claim directly underextraVolumes.Additionally, the chart version has been updated to 3.0.0 as this introduces a breaking change compared to the previous version. This does not impact the downstream chart version, which remains at 1.5.0.
Changes
dynamicPlugins.cache.volumeClaimSpecfromvalues.yaml, ensuring all dynamic plugin storage is ephemeral.extraVolumesto define ephemeral volume claims directly, making storage configuration more explicit.ci/with-custom-dynamic-pvc-claim-spec-values.yaml) to reflect how users can specify storage options for the ephemeral volume claim, including storage class configurations.charts/backstage/Chart.yamlversion to3.0.0, marking this as a breaking change.How to Test
Deploy the updated chart and verify that no PVC is created by default:
Existing or Associated Issue(s)
https://issues.redhat.com/browse/RHIDP-5569
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.