Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-13199) meson: fix installation of ukify #215

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

keszybz
Copy link
Contributor

@keszybz keszybz commented Dec 8, 2023

ln_s was added in upstream later on. It's not present in this branch. Fixup for b98da2d.

Related: RHEL-13199

ln_s was added in upstream later on. It's not present in this branch.
Fixup for b98da2d.

Related: RHEL-13199
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Tracker - RHEL-13199

The following commits need an inspection

commit note
54901d2 - meson: fix installation of ukify Missing upstream reference ‼️

@github-actions github-actions bot changed the title meson: fix installation of ukify (RHEL-13199) meson: fix installation of ukify Dec 8, 2023
@jamacku jamacku changed the base branch from rhel-9.4.0 to main December 8, 2023 18:44
@jamacku jamacku added this to the RHEL-9.4.0 milestone Dec 8, 2023
@mrc0mmand
Copy link
Member

00:08:16.347 Message: Skipping ukify.1 because ENABLE_UKIFY is false

Ah, that's why CIs didn't catch it. Lemme fix that.

@jamacku jamacku removed the rhel-9.4.0 label Dec 8, 2023
@mrc0mmand
Copy link
Member

 353/1406 systemd:ukify / test-ukify                                                              OK                0.71s

Yup, now it seems to run the tests as well. The TEST-17-UDEV fail in the sanitizers run is unrelated, though concerning, I'll look into that later.

Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Dec 11, 2023
@github-actions github-actions bot merged commit a1bd733 into redhat-plumbers:main Dec 11, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants