Draft
Conversation
jhodapp
added
documentation
jhodapp
changed the title
jhodapp
force-pushed
the
docs/goals-implementation-plans
branch
from
ddab7f3 to
2639a98
Compare
Add two planning documents for the goals feature implementation: - goals-feature-master-plan.md: framing doc with PR dependency graph, API gap analysis, and layer-by-layer implementation plan - goals-backend-questions.md: four architectural questions (goal scoping, action-goal FK, SSE events, annotation persistence) to resolve with the backend team before frontend work begins
All four backend questions (Q1–Q4) are now resolved: - Q1: Join table (coaching_sessions_goals) confirmed - Q2: Direct goal_id FK on actions confirmed - Q3: Renamed SSE events + two new join table events - Q4: Both SSE + load-time validation with per-entity-type endpoints Also incorporates rename decisions: overarching_goals → goals, coaching_session_id → created_in_session_id, and backend 5-PR plan.
- Rename GET /goals/{id}/health_metrics → GET /goals/{id}/health
to match backend's GoalsFeatureEndpointReference contract
- Clarify health heuristics: momentum-only when target_date is null
- Incorporate created_in_session_id nullable decision
- Incorporate target_date field decision
…rd workflow
- Mark DELETE /goals/{id} as confirmed in PR2
- Specify coaching_relationship_id as NOT NULL with backfill migration
- Add CASCADE on both join table FKs, join table backfill from existing data
- Clarify MAX=3 per-session limit is frontend-only enforcement
- Add coordinated deploy warning for PR2 breaking change
- Add goal-session carry-forward workflow (auto-link active goals at session creation)
- Consolidate PR2 scope (DELETE endpoint, query params) and PR4 scope (health endpoint)
- Remove stale "verify/add" and "additional backend work" items
- GET /goals now requires coaching_relationship_id for backend auth
- created_in_session_id is display metadata only, not a query filter
- For session-linked goals, frontend uses GET /coaching_sessions/{id}/goals
- Update API gap table, coordinated deploy warning, and Q1 decisions
Mark backend PR1/PR2 as merged with links to PRs (#242, #330). Update API gap analysis with PR2 completion status. Correct active goal limit from frontend-only to backend-enforced (409 Conflict). Update join table endpoints to nested routes. Add Layer 2 PR2 companion deliverables and remaining work blockers. Document auto-link on creation interim behavior.
jhodapp
force-pushed
the
docs/goals-implementation-plans
branch
from
fca0edf to
479f4db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
These planning docs establish the roadmap for turning the goals prototypes (
src/app/prototype/) into production code across 10 PRs organized in 5 layers. No code changes — documentation only.