Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated input file generisdata_nur_ren.prn #1837

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

lecfab
Copy link
Contributor

@lecfab lecfab commented Sep 23, 2024

Purpose of this PR

See @robertpietzcker's comment #1782 (comment): The values in generisdata_nur_ren.prn are outdated and overwritten in files f_maxProdGradeRegi*.cs3r. This PR removes the outdated file,

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here: /p/tmp/fabricel/nurPrnRemoval-remind
  • Comparison of results (what changes by this PR?): nothing changes, see /p/tmp/fabricel/nurPrnRemoval-remind/compScen-nurPrnRemoval-2024-09-25_20.51.30-H12.pdf

@@ -68,39 +69,37 @@ q32_limitCapTeStor(t,regi,teStor)$( t.val ge 2020 ) ..
=l=
sum(te2rlf(teStor,rlf),
vm_capFac(t,regi,teStor)
* pm_dataren(regi,"nur",rlf,teStor)
Copy link
Contributor Author

@lecfab lecfab Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this factor as value was always 1 for storage technologies.

@lecfab lecfab mentioned this pull request Sep 23, 2024
14 tasks
core/datainput.gms Outdated Show resolved Hide resolved
@fbenke-pik fbenke-pik removed their request for review September 26, 2024 08:04
@lecfab lecfab merged commit a223150 into remindmodel:develop Sep 26, 2024
2 checks passed
@lecfab lecfab deleted the nurPrnRemoval branch September 26, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants