fix: RouteConfig default overrides global enable_penetration_detection=False #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enable_penetration_detection=False RouteConfig.__init__ hardcoded enable_suspicious_detection=True, which unconditionally overrode the global SecurityConfig.enable_penetration_detection in _get_effective_penetration_setting(). This meant setting enable_penetration_detection=False had no effect when a RouteConfig was present. Changed the default to None and added a None check so route-level config only overrides the global setting when explicitly set via decorators. Fixes rennf93#72
Owner
|
Thanks for the PR! As I explained in #72 , this isn't actually a bug. The decorator system already handles the sync via _ensure_route_config(). The reproduction in the issue bypasses the library's API by directly instantiating RouteConfig() and calling a private function. Closing this alongside the issue. Thanks for looking into it though. Have a great one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Problem
RouteConfig.__init__hardcodesenable_suspicious_detection = True. When_get_effective_penetration_setting()encounters anyRouteConfig(even the default one), it unconditionally overrides the globalSecurityConfig.enable_penetration_detectionsetting. This means settingenable_penetration_detection=Falsehas no effect when aRouteConfigis present on the request.Fix
RouteConfig.enable_suspicious_detectiondefault fromTruetoNoneNonecheck in_get_effective_penetration_setting()so route-level config only takes effect when explicitly set via decoratorsDecorator-created route configs still work correctly because
_ensure_route_config()explicitly setsenable_suspicious_detectionfromconfig.enable_penetration_detection.