Skip to content

fix: RouteConfig default overrides global enable_penetration_detection=False #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MihaiStreames wants to merge 1 commit into from
Closed

fix: RouteConfig default overrides global enable_penetration_detection=False #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions guard/core/checks/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,9 @@ def _get_effective_penetration_setting(
penetration_enabled = config.enable_penetration_detection

if route_config and hasattr(route_config, "enable_suspicious_detection"):
route_specific_detection = route_config.enable_suspicious_detection
penetration_enabled = route_specific_detection
if route_config.enable_suspicious_detection is not None:
route_specific_detection = route_config.enable_suspicious_detection
penetration_enabled = route_specific_detection

return penetration_enabled, route_specific_detection

Expand Down
2 changes: 1 addition & 1 deletion guard/decorators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(self) -> None:
self.max_request_size: int | None = None
self.allowed_content_types: list[str] | None = None
self.time_restrictions: dict[str, str] | None = None
self.enable_suspicious_detection: bool = True
self.enable_suspicious_detection: bool | None = None
self.require_referrer: list[str] | None = None
self.api_key_required: bool = False
self.session_limits: dict[str, int] | None = None
Expand Down
Loading