-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyzag integration #162
base: main
Are you sure you want to change the base?
pyzag integration #162
Conversation
|
Syntax checkNo syntax error, good job! 💜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A preemptive approve before pyzag arrives.
c37912f
to
fea276c
Compare
python/examples/statistical.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to check in jupyter notebooks. The metadata of the notebook will change everytime you open and save the notebook unless we require users to modify their nb global config.
One approach is to convert jupyter notebooks to python scripts using something like jupytext. They also offer a pre commit hook.
This rich nb diff feature allows me to review nb changes on github: https://github.blog/changelog/2023-03-01-feature-preview-rich-jupyter-notebook-diffs/ Two caveats:
|
…but no more code changes should be required
3b4f84a
to
3d2fdb3
Compare
Provide pyzag wrappers for neml2 models and demos on how to train models versus synthetic data.