Fix memory allocation bug in ImplicitUpdate

[hugary1995]

We have been allocating unnecessary 2nd derivative storage for the implicit model solved by ImplicitUpdate. This PR fixes that bug.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-16 15:57 UTC

[reverendbedford]

Syntax check

No syntax error, good job! 💜

[github-actions]

Test Results (ubuntu-latest-Release-ON)

    3 files  ±0      3 suites  ±0   32s ⏱️ -2s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 150 runs  ±0  3 150 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (macos-12-Debug-ON)

    3 files  ±0      3 suites  ±0   1m 24s ⏱️ -13s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 152 runs  ±0  3 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (ubuntu-latest-Debug-ON)

    3 files  ±0      3 suites  ±0   1m 22s ⏱️ -6s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 152 runs  ±0  3 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (macos-12-Release-ON)

    3 files  ±0      3 suites  ±0   56s ⏱️ -15s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 150 runs  ±0  3 150 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Python Binding Test Results (macos-12)

76 tests  ±0   52 ✅ ±0   1s ⏱️ -2s
 1 suites ±0   24 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Python Binding Test Results (ubuntu-latest)

76 tests  ±0   52 ✅ ±0   1s ⏱️ ±0s
 1 suites ±0   24 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (macos-12-Release-OFF)

    3 files  ±0      3 suites  ±0   43s ⏱️ -2s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 150 runs  ±0  3 150 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (ubuntu-latest-Release-OFF)

    3 files  ±0      3 suites  ±0   32s ⏱️ -2s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 150 runs  ±0  3 150 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[reverendbedford]

Coverage after merging oom into main will be

94.24%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src/neml2/base
CrossRef.cxx	83.87%	100%	75%	100%
DiagnosticsInterface.cxx	71.70%	100%	66.67%	72.73%	59, 62–64, 75, 78–80, 83, 86–88
EnumSelection.cxx	100%	100%	100%	100%
Factory.cxx	98.21%	100%	100%	97.83%	46
HITParser.cxx	100%	100%	100%	100%
NEML2Object.cxx	91.67%	100%	100%	90%	35
OptionCollection.cxx	100%	100%	100%	100%
OptionSet.cxx	100%	100%	100%	100%
Registry.cxx	75%	100%	66.67%	76.92%	38, 40–41, 56, 58–59
Settings.cxx	96.49%	100%	100%	96.36%	121, 126
src/neml2/drivers
Driver.cxx	91.67%	100%	100%	90%	39
TransientDriver.cxx	99%	100%	100%	98.91%	102, 272
src/neml2/drivers/solid_mechanics
LargeDeformationIncrementalSolidMechanicsDriver.cxx	94.67%	100%	100%	94.37%	63, 81, 83–84
SolidMechanicsDriver.cxx	99.11%	100%	100%	99.07%	77
src/neml2/misc
error.cxx	100%	100%	100%	100%
math.cxx	95.74%	100%	93.55%	96.18%	249, 315, 317–318, 341, 343
parser_utils.cxx	98.46%	100%	100%	98.18%	64
types.cxx	100%	100%	100%	100%
utils.cxx	90.91%	100%	100%	88.24%	52, 60
src/neml2/models
ArrheniusParameter.cxx	97.22%	100%	100%	96.97%	54
BackwardEulerTimeIntegration.cxx	92.59%	100%	75%	97.62%	56
BufferStore.cxx	73.33%	100%	66.67%	75%	36, 38, 40
ComposedModel.cxx	91.98%	100%	100%	91.44%	233, 235, 367, 375, 377–378, 386–387, 390, 392, 394, 396–399, 406, 417, 62, 99
ConstantParameter.cxx	52.11%	100%	40.74%	88.24%	43, 61
CopyVariable.cxx	54.05%	100%	38.89%	95%	46
Data.cxx	90%	100%	100%	87.50%	35
ForwardEulerTimeIntegration.cxx	86.27%	100%	66.67%	92.31%	55, 64, 96
ImplicitUpdate.cxx	95.51%	100%	100%	95.18%	122, 135, 172, 48
InputParameter.cxx	52.05%	100%	37.04%	94.74%	42
LinearCombination.cxx	94.44%	100%	75%	100%
LinearInterpolation.cxx	92.86%	100%	77.78%	96.97%	41
Model.cxx	96.50%	100%	97.83%	96.33%	246, 317, 52, 525, 557, 588, 615, 617–619, 621–622, 645
NonlinearParameter.cxx	61.90%	100%	55.56%	100%
ParameterStore.cxx	73.68%	100%	37.04%	85.06%	112, 138, 185, 187–188, 191–192, 199, 57, 59–61, 89
RotationMatrix.cxx	96%	100%	100%	95.45%	45
SR2Invariant.cxx	92.59%	100%	100%	92.31%	119, 144, 159–160, 77, 93
VariableRate.cxx	90.74%	100%	66.67%	97.62%	53
VariableStore.cxx	100%	100%	100%	100%
WR2ExplicitExponentialTimeIntegration.cxx	79.17%	100%	75%	79.55%	50, 59, 66, 68–72, 93
WR2ImplicitExponentialTimeIntegration.cxx	96.08%	100%	100%	95.74%	57, 66
src/neml2/models/crystallography
CrystalGeometry.cxx	98.46%	100%	100%	98.25%	197, 59
CubicCrystal.cxx	93.75%	100%	100%	92.86%	51
MillerIndex.cxx	100%	100%	100%	100%
crystallography.cxx	98.28%	100%	100%	98.08%	127
src/neml2/models/crystallography/user_tensors
FillMillerIndex.cxx	94.44%	100%	100%	93.33%	44
SymmetryFromOrbifold.cxx	93.33%	100%	100%	92.31%	47
src/neml2/models/solid_mechanics
AssociativeIsotropicPlasticHardening.cxx	96.67%	100%	100%	96.30%	50
AssociativeKinematicPlasticHardening.cxx	96.88%	100%	100%	96.55%	52
AssociativePlasticFlow.cxx	96.55%	100%	100%	96.15%	50
ChabochePlasticHardening.cxx	97.96%	100%	100%	97.83%	66
Eigenstrain.cxx	90.91%	100%	100%	88.89%	38
Elasticity.cxx	96%	100%	100%	95.65%	52
FlowRule.cxx	92.31%	100%	100%	90.91%	40
GTNYieldFunction.cxx	99.50%	100%	100%	99.49%	75
GursonCavitation.cxx	96.97%	100%	100%	96.67%	49
IsotropicHardening.cxx	93.33%	100%	100%	92.31%	42
IsotropicMandelStress.cxx	93.33%	100%	100%	92.31%	40
KinematicHardening.cxx	93.33%	100%	100%	92.31%	42
KocksMeckingActivationEnergy.cxx	97.73%	100%	100%	97.56%	63
KocksMeckingFlowSwitch.cxx	97.83%	100%	100%	97.67%	60
KocksMeckingFlowViscosity.cxx	98.86%	100%	100%	98.82%	65
KocksMeckingRateSensitivity.cxx	98.28%	100%	100%	98.18%	54
KocksMeckingYieldStress.cxx	96.88%	100%	100%	96.55%	47
LinearIsotropicElasticity.cxx	97.73%	100%	100%	97.56%	50
LinearIsotropicHardening.cxx	95.24%	100%	100%	94.44%	42
LinearKinematicHardening.cxx	95.24%	100%	100%	94.44%	43
MandelStress.cxx	93.33%	100%	100%	92.31%	42
MixedControlSetup.cxx	98.18%	100%	100%	98.04%	64
Normality.cxx	98.18%	100%	100%	98.04%	52
OlevskySinteringStress.cxx	96.97%	100%	100%	96.67%	54
PerzynaPlasticFlowRate.cxx	97.22%	100%	100%	96.97%	49
PlasticFlowRate.cxx	92.86%	100%	100%	91.67%	41
RateIndependentPlasticFlowConstraint.cxx	96.97%	100%	100%	96.67%	47
ThermalEigenstrain.cxx	96.30%	100%	100%	95.83%	51
VoceIsotropicHardening.cxx	96.30%	100%	100%	95.83%	47
YieldFunction.cxx	97.50%	100%	100%	97.30%	53
src/neml2/models/solid_mechanics/crystal_plasticity
ElasticStrainRate.cxx	97.67%	100%	100%	97.50%	62
FixOrientation.cxx	96.97%	100%	100%	96.67%	55
LinearSingleSlipHardeningRule.cxx	95.45%	100%	100%	94.74%	44
OrientationRate.cxx	97.67%	100%	100%	97.50%	62
PlasticDeformationRate.cxx	97.44%	100%	100%	97.22%	62
PlasticVorticity.cxx	97.37%	100%	100%	97.14%	61
PowerLawSlipRule.cxx	97.06%	100%	100%	96.77%	51
ResolvedShear.cxx	97.50%	100%	100%	97.30%	59
SingleSlipHardeningRule.cxx	95.24%	100%	100%	94.74%	52
SingleSlipStrengthMap.cxx	96%	100%	100%	95.45%	49
SlipRule.cxx	95.83%	100%	100%	95.45%	55
SlipStrengthMap.cxx	94.12%	100%	100%	93.33%	47
SumSlipRates.cxx	96.77%	100%	100%	96.43%	55
VoceSingleSlipHardeningRule.cxx	96.43%	100%	100%	96%	48
src/neml2/solvers
Newton.cxx	90.38%	100%	100%	88.89%	40, 59, 61–62, 64
NewtonWithLineSearch.cxx	90.20%	100%	100%	89.36%	53, 89–92
NewtonWithTrustRegion.cxx	88.68%	100%	100%	87.76%	109, 149–155, 182–184, 78
NonlinearSolver.cxx	94.44%	100%	100%	93.75%	45
NonlinearSystem.cxx	89.60%	100%	93.75%	88.99%	104–105, 124–125, 166, 168–170, 51, 85, 95–96
Solver.cxx	91.67%	100%	100%	90%	39
TrustRegionSubProblem.cxx	100%	100%	100%	100%
src/neml2/tensors
LabeledAxis.cxx	80.63%	100%	91.67%	79.29%	137, 153, 157–159, 179, 189, 216, 268, 270, 272–274, 276–278, 280–281, 299, 312–313, 317, 335, 351, 357, 360, 367, 370–372, 374–378, 381, 384–386, 389–390
LabeledAxisAccessor.cxx	97.33%	100%	100%	96.61%	109–110
LabeledMatrix.cxx	100%	100%	100%	100%
LabeledTensor.cxx	66.67%	100%	52.63%	80.70%	134, 136, 141, 143–144, 169, 171, 176, 178–179, 183, 185, 318, 329, 68–70, 72, 76, 78–80
LabeledTensor3D.cxx	100%	100%	100%	100%
LabeledVector.cxx	94.12%	100%	100%	92.86%	50
Quaternion.cxx	100%	100%	100%	100%
R2.cxx	80%	100%	75%	81.82%	54, 56
R2Base.cxx	100%	100%	100%	100%
R3.cxx	100%	100%	100%	100%
R4.cxx	89.74%	100%	87.50%	90.32%	42–43, 45
Rot.cxx	94.44%	100%	90.91%	95.08%	38–39, 41
SR2.cxx	100%	100%	100%	100%
SSR4.cxx	87.67%	100%	81.25%	89.47%	124, 126, 130, 132, 136, 138
SWR4.cxx	100%	100%	100%	100%

[github-actions]

Test Results (macos-12-Debug-OFF)

    3 files  ±0      3 suites  ±0   1m 23s ⏱️ -7s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 152 runs  ±0  3 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.

[github-actions]

Test Results (ubuntu-latest-Debug-OFF)

    3 files  ±0      3 suites  ±0   1m 22s ⏱️ -4s
  517 tests ±0    517 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 152 runs  ±0  3 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 245694d. ± Comparison against base commit 884615b.