refactor: add rosdep rules folder and documentation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This commit adds a custom [rosdep](https://wiki.ros.org/rosdep) rules folder and documentation. This was done to resolve conflicting requirements between the `python3-gymnasium-pip` and `python3-gymnasium-robotics` rules and the `python3-numpy` rule on [Ubuntu 20.04](https://releases.ubuntu.com/focal/). Specifically, `gymnasium` requires `numpy>=1.20.1`, but the `python3-numpy` rule installs `numpy==1.17.4` (see ros/rosdistro#38332).
rickstaa
force-pushed
the
add_rosdep_rules
branch
from
f25b5eb
to
bf6aefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a custom rosdep rules folder and documentation. This was done to resolve
conflicting requirements between the
python3-gymnasium-pipandpython3-gymnasium-roboticsrules and thepython3-numpyrule on Ubuntu 20.04. Specifically,gymnasiumrequiresnumpy>=1.20.1, but thepython3-numpyrule installsnumpy==1.17.4(see ros/rosdistro#38332).Important
Should be merged after ros/rosdistro#38341, ros/rosdistro#38244 and .