Skip to content

Fixes issue of pyquil-for-azure-quantum not working with new releases of azure-quantum #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixes issue of pyquil-for-azure-quantum not working with new releases of azure-quantum #11

wants to merge 2 commits into from

Conversation

vxfield
Copy link

@vxfield vxfield commented Mar 2, 2023

Superseded by #12

Problem

The current 0.0.2 release of pyquil-for-azure-quantum does not work with new releases of the azure-quantum package because the current dependency constraint ^0.25.218240 effectively becomes <0.26.0,>=0.25.218240 and every month Microsoft creates a new release of azure-quantum that increments the minor version.

When doing a pip install for both latest releases of pyquil-for-azure-quantum and azure-quantum, PIP returns this error:

pyquil-for-azure-quantum 0.0.2 requires azure-quantum<0.26.0,>=0.25.218240, but you have azure-quantum 0.27.258449 which is incompatible.

Fix

This PR relaxes the dependency constraint of azure-quantum to be >=0.27,<1.0.

It also increments the version of pyquil-for-azure-quantum to 0.0.3 expecting that a new package will be released with the updated dependency constraint.

@vxfield vxfield changed the title Fixes issue with pyquil-for-azure-quantum not working with new releases of azure-quantum Fixes issue of pyquil-for-azure-quantum not working with new releases of azure-quantum Mar 2, 2023
@Shadow53
Copy link
Contributor

Hi @vxfield, thanks for the pull request!

CI is currently failing due to a couple errors -- if you address them in your branch, I can re-run CI and see if everything passes.

Installing dependencies from lock file
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it.

Because pyquil-for-azure-quantum depends on azure-quantum (>=0.27,<1.0) which doesn't match any versions, version solving failed.

@vxfield
Copy link
Author

vxfield commented Mar 12, 2023

@Shadow53, I have updated the poetry.lock file.

@vxfield
Copy link
Author

vxfield commented Mar 12, 2023

@Shadow53, I just noticed you have open #12 to fix the issue.
I'll close this PR and you can take it from there.

@vxfield vxfield closed this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants