feat: add CTID support #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ckniffen
pushed a commit
that referenced
this pull request
Oct 2, 2023
This PR fixes an issue where prices showed up weirdly on the `OfferCreate` price currency pair. Noticed while working on #839
ckniffen
reviewed
Oct 13, 2023
ckniffen
reviewed
Oct 13, 2023
ckniffen
reviewed
Oct 13, 2023
|
I created some suggestions here. d0bed1e |
- Removed needed `?` - Use real spaces instead of margins - Remove styling for `.summary .label` that is unused - Rearrange spacing of elements by using margins and padding differently and taking use of margin collapsing. - convert Transaction page test to typescript
jonathanlei
approved these changes
Oct 18, 2023
mvadari
commented
Oct 18, 2023
pdp2121
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add CTID support to the search and URLs.
Context of Change
Fixes #707
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Test Plan
Added tests. CI passes.