Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes on model 'torqueControlBalancingWithSimu.mdl' #129

Conversation

nunoguedelha
Copy link
Contributor

Fixes #125 .

- Converted boolean flags to enumerations.
- Introduced None/Warning/EmergencyStop choices.
@nunoguedelha nunoguedelha marked this pull request as ready for review May 20, 2021 04:23
@nunoguedelha
Copy link
Contributor Author

Since this is already approved, and for keeping a commit history the more linear possible, I can merge this to fix/reflect-mwbs#49-remove-dependency-from-wbc branch (Fast-Forward), i.e. on top of #128 .

Fine to you guys? @traversaro @gabrielenava @Giulero

@nunoguedelha nunoguedelha changed the base branch from master to fix/reflect-mwbs#49-remove-dependency-from-wbc May 20, 2021 15:11
@nunoguedelha
Copy link
Contributor Author

Fine to you guys? @traversaro @gabrielenava @Giulero

This is a trivial operation, I'll just proceed, I think you guys are busy with ironcub tests etc.

@traversaro
Copy link
Member

Since this is already approved, and for keeping a commit history the more linear possible, I can merge this to fix/reflect-mwbs#49-remove-dependency-from-wbc branch (Fast-Forward), i.e. on top of #128 .

Fine to you guys? @traversaro @gabrielenava @Giulero

Ok for me!

@nunoguedelha nunoguedelha merged commit 142a0b5 into fix/reflect-mwbs#49-remove-dependency-from-wbc May 20, 2021
@nunoguedelha nunoguedelha deleted the fix/#125-minor-fixes branch May 20, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor fixes and improvements of the YOGA-controller+matlab-simulator model
2 participants