Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last day of month/year bug in epochMillisToDateTimeHelp function #25

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

imclerran
Copy link
Contributor

Fix for issue #24, along with test cases to demonstrate fix.

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 29, 2024

Blocked on #22

@imclerran imclerran changed the title Fix date comparison bug in epochMillisToDateTimeHelp function Fix bug in epochMillisToDateTimeHelp function Jan 29, 2024
@imclerran imclerran changed the title Fix bug in epochMillisToDateTimeHelp function Fix last day of month/year bug in epochMillisToDateTimeHelp function Jan 29, 2024
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely :)

@Anton-4 Anton-4 merged commit a91f54c into roc-lang:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants