Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last day of month/year bug in epochMillisToDateTimeHelp function #25

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Fix last day of month/year bug in epochMillisToDateTimeHelp function #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efae299
Fix date comparison bug in epochMillisToDateTimeHelp function
imclerran Jan 29, 2024
4bb3927
modify new test cases to match style of previous tests
imclerran Jan 29, 2024
c533785
Merge branch 'roc-lang:main' into main
imclerran Jan 30, 2024
b16d2e6
Merge branch 'main' into main
Anton-4 Jan 30, 2024
205b977
test InternalDateTime in CI
Anton-4 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/all_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,7 @@ done

$roc test platform/Url.roc

$roc test platform/InternalDateTime.roc

# test building website
$roc docs platform/main.roc
15 changes: 13 additions & 2 deletions platform/InternalDateTime.roc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ epochMillisToDateTimeHelp = \current ->
countDaysInYear = if isLeapYear current.year then 366 else 365
countDaysInMonth = daysInMonth current.year current.month

if current.day >= countDaysInYear then
if current.day > countDaysInYear then
epochMillisToDateTimeHelp {
year: current.year + 1,
month: current.month,
Expand All @@ -126,7 +126,7 @@ epochMillisToDateTimeHelp = \current ->
minutes: current.minutes - (countDaysInYear * 24 * 60),
seconds: current.seconds - (countDaysInYear * 24 * 60 * 60),
}
else if current.day >= countDaysInMonth then
else if current.day > countDaysInMonth then
epochMillisToDateTimeHelp {
year: current.year,
month: current.month + 1,
Expand All @@ -142,6 +142,17 @@ epochMillisToDateTimeHelp = \current ->
seconds: current.seconds % 60,
}


# test last day of 1st year after epoch
expect
str = (364 * 24 * 60 * 60 * 1000) |> epochMillisToDateTime |> toIso8601Str
str == "1970-12-31T00:00.00Z"

# test last day of 1st month after epoch
expect
str = (30 * 24 * 60 * 60 * 1000) |> epochMillisToDateTime |> toIso8601Str
str == "1970-01-31T00:00.00Z"

# test 1_700_005_179_053 ms past epoch
expect
str = 1_700_005_179_053 |> epochMillisToDateTime |> toIso8601Str
Expand Down
Loading