io: Support 64 bits position/byte-count #21183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 8h 35m 32s ⏱️ For more details on these failures, see this check. Results for commit a74d03a. |
Contributor
|
The first commit message didn't get reworded, I think. Cf. #20574 (comment) |
jblomer
approved these changes
Feb 7, 2026
pcanal
changed the title
In order to support 64 bits byte counts, which do not fit in the space reserved for them in the stream (4 bytes minus 2 control bits) and to work around the fact that the variables that holds the position and the byte count information in Streamer functions are only 32 bits (see arguments to TBufferFile::WriteVersion and TBufferFile::ReadVersion), we need to pass them indirectly when they needs 64 bits Since the streaming is inherently serial, we can leverage the sequence of calls and cache the 64 bits values in a queue. The bytecount that can not be stored in place inside the io stream will be held in a collection (fByteCounts) that need to be stored externally to the buffer.
Note to store and restore the larger than 1GB byte count use:
// Copy the content of the const reference.
auto bytecounts{b.GetByteCounts()};
...
b.SetByteCounts(std::move(bytecounts));
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
a74d03a to
f4ab521
Compare
Member
Author
Correct. I have now pushed the revised version. |
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
f4ab521 to
5a57c54
Compare
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
3b2bf1e to
588b29e
Compare
Member
Author
|
Review continues at #21192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation/Replacement of #20574 with a new incoming branch name to enable proper testing.